xiayanzheng opened a new pull request, #21180: URL: https://github.com/apache/superset/pull/21180
<!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> ### SUMMARY <!--- Describe the change below, including rationale and design decisions --> We want add snowflake in superset, but our snowflake is using SSO authentication so we can't add it with built-in snowflake connector, we found we can connect it with snowflake keypair authentication. so I modified connector file to support keypair authentication. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> BEFORE: I can't add snowflake with keypair authentication AFTER： We can add two parameters in SQLALCHEMY URI. privatekey={privatekey path on server} privatekeypw={privatekey password} Like this: snowflake://{user}:{password}@{account}/{database}?role={role}&warehouse={warehouse}&schema={schema}&privatekey={privatekey path on server}&privatekeypw={privatekey password}  ### TESTING INSTRUCTIONS <!--- Required! What steps can be taken to manually verify the changes? --> 1. Follow this [document](https://docs.snowflake.com/en/user-guide/key-pair-auth.html) to create and bind keypair to snowflake 2. Upload private key file(.p8 file) to server(ie. /app/rsa_key.p8) 3. In Superset web page, add database, select "Other" option in SUPPORTED DATABASES dropdown. 4. Add SQLALCHEMY URI with following format. snowflake://{user}:{password}@{account}/{database}?role={role}&warehouse={warehouse}&schema={schema}&privatekey={privatekey path on server}&privatekeypw={privatekey password} 5. Click connect ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [x] Has associated issue: https://github.com/apache/superset/discussions/21107 - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [x] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
