dpgaspar commented on code in PR #21180:
URL: https://github.com/apache/superset/pull/21180#discussion_r958305090
##########
superset/databases/commands/test_connection.py:
##########
@@ -73,8 +74,12 @@ def run(self) -> None:
database.set_sqlalchemy_uri(uri)
database.db_engine_spec.mutate_db_for_connection_test(database)
-
- engine = database.get_sqla_engine()
+
+ engine = None
+ if "snowflake" in str(url) and "privatekey" in str(url):
Review Comment:
possibly the best path would be to use `encryption_extra`, using the
database URI with sensitive information like a private key leads to the
following security issues:
- sqlalchemy_uri is not encrypted on the db (but password is, this is the
only secret expected on the URI)
- disclosure of sensitive info through the API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
