mebegu commented on code in PR #21180:
URL: https://github.com/apache/superset/pull/21180#discussion_r960773037
##########
superset/databases/commands/test_connection.py:
##########
@@ -73,8 +74,12 @@ def run(self) -> None:
database.set_sqlalchemy_uri(uri)
database.db_engine_spec.mutate_db_for_connection_test(database)
-
- engine = database.get_sqla_engine()
+
+ engine = None
+ if "snowflake" in str(url) and "privatekey" in str(url):
Review Comment:
If we run the superset from docker container, are we gonna be able to read
the private_key file from the host with given file path?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
