justinpark opened a new pull request, #21316:
URL: https://github.com/apache/superset/pull/21316

   ### SUMMARY
   
   Reopen: #21141
   
   Since DatabaseSelector component has an unnecessary key, DatabaseSelector 
will be re-mounted  rather than update whenever currentDatabase object is 
updated. This causes the unexpected duplicate database list api request.
   This commit removes this key so will skip unnecessary re-rendering and data 
fetching.
   It also fixes the logic for currentDb that directly transform from db 
instead of useState.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   Before:
   
   
![fix--unnecessary-dabaseselector-rerendering](https://user-images.githubusercontent.com/1392866/185713445-a22e86e1-9382-4ecc-81a4-bdb692d016d1.gif)
   
   After:
   
   ![Screen Shot 2022-08-19 at 2 50 12 
PM](https://user-images.githubusercontent.com/1392866/185713454-b6a05d82-2162-4b6d-9fab-13d36a209401.png)
   
   ### TESTING INSTRUCTIONS
   go to Sql Editor and check the network list
   
   ### ADDITIONAL INFORMATION
   - [x] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   cc: @ktmud 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to