justinpark commented on PR #21316: URL: https://github.com/apache/superset/pull/21316#issuecomment-1248604076
> Is there a reason for removing AsyncSelect useEffect dependencies? @michael-s-molina Because fetchPage kept changing while initializing due to the object dependencies, useEffect has been triggered multiple times which causes unnecessary `fetchPage` calls. I made [a change](https://github.com/apache/superset/pull/21316/commits/243ba07e55d24eb3c007f58557ddde68dcd139e9) to reduce and fix the dependencies for fetchPage and rollback this useEffect dependencies. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
