AAfghahi commented on code in PR #21241:
URL: https://github.com/apache/superset/pull/21241#discussion_r966448578
##########
superset-frontend/src/views/CRUD/data/dataset/AddDataset/Footer/Footer.test.tsx:
##########
@@ -20,10 +20,47 @@ import React from 'react';
import { render, screen } from 'spec/helpers/testing-library';
import Footer from 'src/views/CRUD/data/dataset/AddDataset/Footer';
+const mockedProps = {
+ url: 'realwebsite.com',
+};
+
+const mockPropsWithDataset = {
+ url: 'realwebsite.com',
+ datasetObject: {
+ database: {
+ id: '1',
+ database_name: 'examples',
+ },
+ owners: [1, 2, 3],
+ schema: 'public',
+ dataset_name: 'Untitled',
+ table_name: 'real_info',
+ },
+};
+
describe('Footer', () => {
- it('renders a blank state Footer', () => {
- render(<Footer />);
Review Comment:
This is a good question. This was a test that was created as a placeholder
while we were implementing the blank state PR. Now that it is finished we are
changing it to be reflective of the actual behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
