AAfghahi commented on code in PR #21241:
URL: https://github.com/apache/superset/pull/21241#discussion_r966450264
##########
superset-frontend/src/views/CRUD/data/dataset/AddDataset/Footer/index.tsx:
##########
@@ -17,7 +17,65 @@
* under the License.
*/
import React from 'react';
+import Button from 'src/components/Button';
+import { t } from '@superset-ui/core';
+import { useSingleViewResource } from 'src/views/CRUD/hooks';
+import withToasts from 'src/components/MessageToasts/withToasts';
+import { DatasetObject } from '../types';
-export default function Footer() {
- return <div>Footer</div>;
+interface FooterObject {
+ url: string;
+ addDangerToast: () => void;
+ datasetObject?: Partial<DatasetObject> | null;
+ onDatasetAdd?: (dataset: DatasetObject) => void;
}
+
+function Footer({ url, datasetObject, addDangerToast }: FooterObject) {
Review Comment:
I don't think it is that weird. One of these is the footer for the native
Filter the other is for AddDataset. I think that the folder structure helps
differentiate them. How would you rename them?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
