kgabryje commented on code in PR #21315:
URL: https://github.com/apache/superset/pull/21315#discussion_r966861778
##########
superset-frontend/src/explore/components/controls/DndColumnSelectControl/DndMetricSelect.tsx:
##########
@@ -125,7 +126,7 @@ const getMetricsMatchingCurrentDataset = (
}, []);
};
-export const DndMetricSelect = (props: any) => {
+const DndMetricSelect = (props: any) => {
Review Comment:
We definitely should improve typing here... (not in this PR, that's a
general note)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
