kgabryje commented on code in PR #21315:
URL: https://github.com/apache/superset/pull/21315#discussion_r966863476
##########
superset-frontend/packages/superset-ui-chart-controls/src/shared-controls/dndControls.tsx:
##########
@@ -25,43 +26,73 @@ import {
t,
validateNonEmpty,
} from '@superset-ui/core';
-import { ExtraControlProps, SharedControlConfig, Dataset } from '../types';
+import {
+ ExtraControlProps,
+ SharedControlConfig,
+ Dataset,
+ Metric,
+} from '../types';
import { DATASET_TIME_COLUMN_OPTION, TIME_FILTER_LABELS } from '../constants';
-import { QUERY_TIME_COLUMN_OPTION, defineSavedMetrics } from '..';
+import {
+ QUERY_TIME_COLUMN_OPTION,
+ defineSavedMetrics,
+ ColumnOption,
+ ColumnMeta,
+ FilterOption,
+} from '..';
import { xAxisControlConfig } from './constants';
-export const dndGroupByControl: SharedControlConfig<'DndColumnSelect'> = {
+type Control = {
+ savedMetrics?: Metric[] | null;
+ default?: unknown;
+};
+
+export const dndGroupByControl: SharedControlConfig<
Review Comment:
Could you add a comment that will explain the idea behind using props from
non-dnd component in dnd control definition? Might be useful for other
contributors in the future
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
