Antonio-RiveroMartnez commented on code in PR #21065:
URL: https://github.com/apache/superset/pull/21065#discussion_r968636151
##########
superset-frontend/src/views/components/RightMenu.tsx:
##########
@@ -118,8 +118,8 @@ const RightMenu = ({
ALLOWED_EXTENSIONS,
HAS_GSHEETS_INSTALLED,
} = useSelector<any, ExtentionConfigs>(state => state.common.conf);
- const [showModal, setShowModal] = useState<boolean>(false);
- const [engine, setEngine] = useState<string>('');
+ const [showModal, setShowModal] = React.useState<boolean>(false);
Review Comment:
Indeed but the usage of the spied hook is different which might be affecting
why these tests cannot do it that way, either way I'll give a spin to see if it
works that way, if not possible we need to decide whether we move forward with
it as is or not 🤔 I'll keep you posted @AAfghahi , thanks for the input 🎉
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
