villebro commented on code in PR #21326:
URL: https://github.com/apache/superset/pull/21326#discussion_r971674176
##########
Dockerfile:
##########
@@ -45,10 +45,7 @@ RUN cd /app \
######################################################################
# Node stage to deal with static asset construction
######################################################################
-FROM node:16 AS superset-node
-
-ARG NPM_VER=7
-RUN npm install -g npm@${NPM_VER}
+FROM node:16-slim AS superset-node
Review Comment:
I remember `npm@8` ceasing to work when building `superset-frontend` after a
certain patch version (I can't remember which). It may have been resolved
since, but I'm not aware of it having been cleared up yet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
