EugeneTorap commented on code in PR #21326:
URL: https://github.com/apache/superset/pull/21326#discussion_r971681516
##########
Dockerfile:
##########
@@ -45,10 +45,7 @@ RUN cd /app \
######################################################################
# Node stage to deal with static asset construction
######################################################################
-FROM node:16 AS superset-node
-
-ARG NPM_VER=7
-RUN npm install -g npm@${NPM_VER}
+FROM node:16-slim AS superset-node
Review Comment:
**_Version 8 is identical to version 7 except for an engines update_**
Maybe a minor version of `npm@8` was broken but now latest `NodeJS 16` has
stable `npm@8`. If we see github action all is OK and `npm@8` is stable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
