geido commented on code in PR #21497:
URL: https://github.com/apache/superset/pull/21497#discussion_r974155542
##########
superset-frontend/src/explore/components/SaveModal.tsx:
##########
@@ -274,19 +287,10 @@ class SaveModal extends React.Component<SaveModalProps,
SaveModalState> {
{(this.state.alert || this.props.alert) && (
<Alert
type="warning"
- message={
- <>
- {this.state.alert ? this.state.alert : this.props.alert}
- <i
- role="button"
- aria-label="Remove alert"
- tabIndex={0}
- className="fa fa-close pull-right"
- onClick={this.removeAlert.bind(this)}
- style={{ cursor: 'pointer' }}
- />
- </>
- }
+ message={this.state.alert ? this.state.alert : this.props.alert}
Review Comment:
```suggestion
message={this.state.alert || this.props.alert}
```
##########
superset-frontend/src/explore/components/SaveModal.tsx:
##########
@@ -274,19 +287,10 @@ class SaveModal extends React.Component<SaveModalProps,
SaveModalState> {
{(this.state.alert || this.props.alert) && (
<Alert
Review Comment:
Not sure if this was like this before as well, but this alert looks weird in
your video. The text is not horizontally aligned, looks like it is missing an
icon on the left
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
