[GitHub] [superset] codyml commented on a diff in pull request #21497: fix(explore): fix chart save when dashboard deleted

Mon, 19 Sep 2022 05:56:09 -0700 


codyml commented on code in PR #21497:
URL: https://github.com/apache/superset/pull/21497#discussion_r974215596


##########
superset-frontend/src/explore/components/SaveModal.tsx:
##########
@@ -274,19 +287,10 @@ class SaveModal extends React.Component<SaveModalProps, 
SaveModalState> {
         {(this.state.alert || this.props.alert) && (
           <Alert

Review Comment:
   Sorry, that was because I made the error show up by disabling my network 
connection and it made the icon not load.  Here's what it looks like when I 
cause an error to happen via other methods:
   
![localhost_9000_explore__form_data_key=lCqno0lpPD4fU4rtWGdzKzKtvJ4w-qyCaNbpdTrF3PsptagPSiXi1LadPHLg_asV
 
slice_id=210](https://user-images.githubusercontent.com/13007381/191022114-915c9509-9ddb-40e0-9773-a8307a455950.png)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to