codyml commented on code in PR #21497:
URL: https://github.com/apache/superset/pull/21497#discussion_r974828636
##########
superset-frontend/src/explore/components/SaveModal.tsx:
##########
@@ -183,6 +182,14 @@ class SaveModal extends React.Component<SaveModalProps,
SaveModalState> {
}
}
+ // Get chart dashboards
+ let sliceDashboards: number[];
+ promise = promise
+ .then(() => this.props.actions.getSliceDashboards(this.props.slice))
+ .then(dashboards => {
+ sliceDashboards = dashboards;
+ });
+
Review Comment:
I'm actually going to leave out turning the promises into `await`s because
my full PR that included that fix triggered an Explore refresh bug that I think
we're going to work on separately.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
