justinpark opened a new pull request, #21543: URL: https://github.com/apache/superset/pull/21543
### SUMMARY Since the existing dashboardState overwrite the `filter_scopes` directly by the UI state from the filter mapping menu, the `filter_scopes` changes made from json metadata editor can be lost. https://github.com/apache/superset/blob/e438c967c9fd3452d8f5aa811a43bce6ae8ffbd2/superset-frontend/src/dashboard/actions/dashboardState.js#L385-L390 This commit adds the warning message of `filter_scopes` changes and then links to the filter mapping menu for the alternative. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF https://user-images.githubusercontent.com/1392866/191609445-a1756f32-c5a9-44cd-9200-8905f396cb28.mov ### TESTING INSTRUCTIONS - Go to a dashboard - Click "edit" and "edit properties" - Click "advanced" to open json editor - check the warning message ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
