john-bodley commented on code in PR #21543:
URL: https://github.com/apache/superset/pull/21543#discussion_r977064445
##########
superset-frontend/src/dashboard/components/PropertiesModal/index.tsx:
##########
@@ -656,6 +657,23 @@ const PropertiesModal = ({
{t(
'This JSON object is generated dynamically when clicking
the save or overwrite button in the dashboard view. It is exposed here for
reference and for power users who may want to alter specific parameters.',
)}
+ {onlyApply && (
+ <>
+ {' '}
+ {t(
+ 'Please DO NOT overwrite `filter_scopes` metadata.',
Review Comment:
```suggestion
'Please DO NOT overwrite the "filter_scopes" key.',
```
I wonder if `"filter_scopes"` is clearer given it's how the key is
presented. I'm less concerned about the key vs metadata name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
