villebro commented on code in PR #21577:
URL: https://github.com/apache/superset/pull/21577#discussion_r979705093
##########
superset-frontend/packages/superset-ui-chart-controls/src/shared-controls/constants.tsx:
##########
@@ -51,3 +52,29 @@ export const xAxisControlConfig = {
},
default: undefined,
};
+
+export const temporalXAxisMixin = {
Review Comment:
As this is a mixin, we maybe the type could be narrowed down to something
like `Pick[BaseControlConfig, 'label' | 'mapStateToProps']`?
Also, I'm wondering if we should make this a function `getXAXisControlMixin`
that takes an optional argument `dataTypes: GenericDataType[]`, which if
defined, would only return the requested column types? For instance, at some
point in the future I'm assuming we want to support any ordinal or linear
datatypes in this chart type, and in that case we would likely want to support
`GenericDataType.NUMERIC` and `GenericDataType.TEMPORAL`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
