zhaoyongjie commented on code in PR #21577:
URL: https://github.com/apache/superset/pull/21577#discussion_r979759823
##########
superset-frontend/packages/superset-ui-chart-controls/src/shared-controls/constants.tsx:
##########
@@ -51,3 +52,29 @@ export const xAxisControlConfig = {
},
default: undefined,
};
+
+export const temporalXAxisMixin = {
Review Comment:
Thanks for the review and very useful case for this mixin. I changed this
variable from the `temporalXAxisMixin` to the `temporalColumnMixin` and removed
`mapStateToProps` from the original one from `dndGranularitySqlaControl`. I
totally agree with making a function for returning specific column types from
the original datasource. I will refactor this part in separate PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
