codyml commented on PR #21351: URL: https://github.com/apache/superset/pull/21351#issuecomment-1269164471
> Two nits and a question from manual testing: > > * Probably not related to this PR but it looks weird that in the Modal there are two loading icons for both the table content and the Metadatabar cc @kasiazjc > > Video.Game.Sales.mp4 Agreed, will look into separately. > * It is possible to rightclick on a chart when the Modal is open. We should probably disable this possibility as the click isn't behaving correctly anyway > > Video.Game.Sales.1.mp4 Fixed. > * I thought we were supporting the Big number with trendline viz type but it shows that the Drill to detail by is disabled, is that right? Oops, turns out I forgot to add the `Behaviors.DRILL_TO_DETAIL` behavior to Big Number, Big Number w/ Trendline, Graph and Treemap v2, so they were all giving that error. Should be fixed now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
