codyml commented on code in PR #21351:
URL: https://github.com/apache/superset/pull/21351#discussion_r989580335
##########
superset-frontend/src/components/Chart/ChartRenderer.jsx:
##########
@@ -203,14 +205,23 @@ class ChartRenderer extends React.Component {
this.setState({ inContextMenu: true });
}
- handleContextMenuSelected(filters) {
- this.setState({ inContextMenu: false, drillDetailFilters: filters });
+ handleContextMenuSelected() {
+ this.setState({ inContextMenu: false });
}
handleContextMenuClosed() {
this.setState({ inContextMenu: false });
}
+ // When viz plugins don't handle `contextmenu` event, fallback handler
+ // calls `handleOnContextMenu` with `filters: null`.
+ onContextMenuFallback(event) {
+ if (!this.state.inContextMenu) {
+ event.preventDefault();
+ this.handleOnContextMenu(null, event.clientX, event.clientY);
Review Comment:
I think I did what you were suggestion, but let me know if that's not what
you meant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
