codyml commented on code in PR #21351:
URL: https://github.com/apache/superset/pull/21351#discussion_r990190241
##########
superset-frontend/plugins/plugin-chart-echarts/src/BigNumber/BigNumberViz.tsx:
##########
@@ -26,7 +26,7 @@ import {
computeMaxFontSize,
BRAND_COLOR,
styled,
- QueryObjectFilterClause,
+ BinaryQueryObjectFilterClause,
Review Comment:
I think yes, because `DrillDetailTableControls` is currently only set up to
correctly display binary filters (e.g. column = value), and if you change the
type to `QueryObjectFilterClause` there you'll get typing errors that you can't
resolve without adding new logic for displaying the other types. Set filters
and unary filters are definitely possible to add display support for in the
future but in its current state it only works with binary filters.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
