codyml commented on code in PR #21351:
URL: https://github.com/apache/superset/pull/21351#discussion_r990207324
##########
superset-frontend/src/components/Chart/ChartContextMenu.tsx:
##########
@@ -119,7 +131,15 @@ const ChartContextMenu = (
return ReactDOM.createPortal(
<Dropdown
- overlay={menu}
+ overlay={
+ <Menu>
+ {menuItems.length ? (
Review Comment:
Is this necessary? I feel like I've always seen `if (array.length) {...` as
an example of concise/expressive JS, and there are way more instances of `if
(array.length) {...` than `if (array.length > 0) {...` in the codebase.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
