zhaoyongjie commented on code in PR #21351:
URL: https://github.com/apache/superset/pull/21351#discussion_r990241229
##########
superset-frontend/src/components/Chart/ChartContextMenu.tsx:
##########
@@ -119,7 +131,15 @@ const ChartContextMenu = (
return ReactDOM.createPortal(
<Dropdown
- overlay={menu}
+ overlay={
+ <Menu>
+ {menuItems.length ? (
Review Comment:
This is a convention in any language. of course, you can follow your logic.
But what I want to say is that
```
vector.size > 0 // if the array is empty
vector.indexOf(item) > -1 // if a item in a Array
object.property // if this property is undefined/null/0/empty string on the
prototype (it's just js pattern)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
