zhaoyongjie commented on PR #21767:
URL: https://github.com/apache/superset/pull/21767#issuecomment-1283875494

   > "Original Value" option in time grain is a little buggy for me, if you 
select it the selection disappears but if you select it again it appears.
   Yes, It's a bug because the `Original value` and unselected shared the same 
key(`null`) in the selection control. The easiest way to fix this is disabled 
removing the value in the time grain selection. I will fix that in the separate 
PR because it's also on the master branch.
   
   > For charts with "Temporal X-axis", you can't remove the default item with 
the little "x". If there are two options and you choose one that's not default, 
then click the "x", it'll just go back to the original one.
   What I'm trying to say is, this is all original Druid logic. There is no 
default time column in the general-purpose database or general BI. It is a 
little weird design to always place a time column for a generic axis control 
(which is not a temporal x-axis). this is only my personal view, welcome to 
discuss.
   
   > Some charts had a tooltip value that seemed off
   Good catch, I will check it out.
   
   > checking feature flags
   Feature flags are global static constant for the frontend codebase, these 
values can't be reset by the frontend codes because they're Flask application 
context config items, in the other words, the only way to change these configs 
that need to restart the Superset process. 
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Reply via email to