villebro commented on code in PR #21767:
URL: https://github.com/apache/superset/pull/21767#discussion_r1000306129
##########
superset-frontend/src/explore/constants.ts:
##########
@@ -45,6 +45,7 @@ export enum Operators {
LATEST_PARTITION = 'LATEST_PARTITION',
IS_TRUE = 'IS_TRUE',
IS_FALSE = 'IS_FALSE',
+ DATETIME_BETWEEN = 'DATETIME_BETWEEN',
Review Comment:
If I have an open ended range, like "100 years ago", then isn't it rather a
"BEFORE" than a "BETWEEN"? So I would still reconsider renaming this to just
"TEMPORAL" or something else instead of "BETWEEN".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
