villebro commented on code in PR #21931:
URL: https://github.com/apache/superset/pull/21931#discussion_r1004970538
##########
superset/reports/commands/execute.py:
##########
@@ -182,11 +193,11 @@ def _get_url(
**kwargs,
)
- # If we need to render dashboard in a specific sate, use stateful
permalink
+ # If we need to render dashboard in a specific state, use stateful
permalink
dashboard_state = self._report_schedule.extra.get("dashboard")
if dashboard_state:
permalink_key = CreateDashboardPermalinkCommand(
- dashboard_id=self._report_schedule.dashboard_id,
+ dashboard_id=str(self._report_schedule.dashboard_id),
Review Comment:
Mypy actually picked this up. This is due to slugs and ids being used
interchangeably in the codebase (I remember being frustrated about this when
working on the permalink feature). In older dashboard and chart code this is
usually referred to as `id_or_slug` which is a `str`, but in the permalink code
we decided to just go by `(dashboard|chart)_id`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
