zhaoyongjie commented on PR #21931: URL: https://github.com/apache/superset/pull/21931#issuecomment-1293647995
> > > Tested in my local, and work as expected. leave a non-blocked suggestions. > > > Could output the Report/Alert's sender in the logging? Because it's hard to determine who send the notification from the current logging. > > > ``` > > > [2022-10-27 15:38:00,050: INFO/ForkPoolWorker-8] Scheduling alert Test Report eta: 2022-10-27 07:38:00 > > > Executing alert/report, task id: 0aa521ec-670d-4c0f-aec7-78c13fb7ba79, scheduled_dttm: 2022-10-27T07:38:00 > > > [2022-10-27 15:38:00,059: INFO/ForkPoolWorker-8] Executing alert/report, task id: 0aa521ec-670d-4c0f-aec7-78c13fb7ba79, scheduled_dttm: 2022-10-27T07:38:00 > > > session is validated: id 4, executionid: 0aa521ec-670d-4c0f-aec7-78c13fb7ba79 > > > [2022-10-27 15:38:00,060: INFO/ForkPoolWorker-8] session is validated: id 4, executionid: 0aa521ec-670d-4c0f-aec7-78c13fb7ba79 > > > Getting chart from http://127.0.0.1:8088/api/v1/chart/316/data/?format=json&type=post_processed&force=true > > > [2022-10-27 15:38:00,135: INFO/ForkPoolWorker-8] Getting chart from http://127.0.0.1:8088/api/v1/chart/316/data/?format=json&type=post_processed&force=true > > > Would send notification for alert Test Report, to {"target": "[email protected]"} > > > [2022-10-27 15:38:00,398: INFO/ForkPoolWorker-8] Would send notification for alert Test Report, to {"target": "[email protected]"} > > > ``` > > > > > > @zhaoyongjie that's an excellent idea! 👏 I will add it > > Let's avoid logging user emails please The email only showed when `ALERT_REPORTS_NOTIFICATION_DRY_RUN` is Ture. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
