[GitHub] [superset] kgabryje opened a new pull request, #21952: fix(explore): Small changes in metadata bar copy and tooltip placement

[GitBox]

kgabryje opened a new pull request, #21952:
URL: https://github.com/apache/superset/pull/21952

   
   ### SUMMARY
   3 small changes in metadata bar in Explore:
   1. Instead of displaying "Added to X dashboard(s)", we display "Added to 1 
dashboard" or "Added to 2 dashboards" (singular vs plural)
   2. Copy fix - changed "You can preview the list of dashboards on the chart 
settings dropdown." to "You can preview the list of dashboards in the chart 
settings dropdown." (prev - "on", now - "in")
   3. Forced the tooltip to always render at the bottom. Before, all tooltips 
rendered at the bottom of metadata bar except for "Not added to any dashboard" 
which was inconsistent.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   Before:
   <img width="584" alt="image" 
src="https://user-images.githubusercontent.com/15073128/198306832-74b5d9f0-7fc5-4add-a57a-ff43d5c7a1c3.png";>
   
   <img width="520" alt="image" 
src="https://user-images.githubusercontent.com/15073128/198306991-eced6b82-ae55-4533-9aac-c30e87913fac.png";>
   
   After:
   
   <img width="512" alt="image" 
src="https://user-images.githubusercontent.com/15073128/198306599-e8f0c433-3336-4c20-b2cb-c16b007a0266.png";>
   
   <img width="551" alt="image" 
src="https://user-images.githubusercontent.com/15073128/198306669-e89a2ccf-5d05-4156-b301-1ff3763fff92.png";>
   
   <img width="595" alt="image" 
src="https://user-images.githubusercontent.com/15073128/198306483-03885a62-30cd-49e3-bc80-018e4132a107.png";>
   
   
   ### TESTING INSTRUCTIONS
   Check metadata bars of charts added to 0, 1 and more than 1 dashboards
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   CC @kasiazjc


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org