[GitHub] [superset] kgabryje commented on a diff in pull request #21952: fix(explore): Small changes in metadata bar copy and tooltip placement

Thu, 27 Oct 2022 08:01:31 -0700 


kgabryje commented on code in PR #21952:
URL: https://github.com/apache/superset/pull/21952#discussion_r1006997431


##########
superset-frontend/src/components/MetadataBar/MetadataBar.tsx:
##########
@@ -149,7 +149,10 @@ const Item = ({
     </StyledItem>
   );
   return isTruncated || collapsed || (tooltip && tooltip !== title) ? (
-    <Tooltip title={<TootipContent>{tooltip}</TootipContent>}>
+    <Tooltip
+      placement="bottom"

Review Comment:
   Good idea. I added prop `tooltipPlacement` to MetadataBar that defaults to 
`top` (just like antd's default) and set it to `bottom` in Explore and in drill 
to detail modal (because in the case of overflowing dataset name, it was also 
showing at the top while the rest of the tooltips were showing at the bottom)
   <img width="730" alt="image" 
src="https://user-images.githubusercontent.com/15073128/198325742-6cc3337b-1db8-4001-a95c-50a5ee4fd30d.png";>
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to