Yann-J opened a new pull request, #21963:
URL: https://github.com/apache/superset/pull/21963

   ### SUMMARY
   
   This PR implements 2 improvements to the releasing of Helm chart:
   - Support for running [helm-docs](https://github.com/norwoodj/helm-docs) to 
generate a README for the chart, automatically generated from the `Chart.yaml` 
and annotated `values.yaml`. It will be enforced both as a `pre-commit` check, 
as well as a CI check.
   - Fix the helm `chart-releaser` action which seems broken due to missing 
dependency on the bitnami chart repo (which prevented the release of the 
updated chart from #21806 ) - this may need some trial & error to confirm a 
successful release.
   
   This PR includes a (useless) bump of the chart version to force the CI to go 
through a Helm release.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   See [generated 
Chart](https://github.com/one-acre-fund/superset/tree/helm-docs/helm/superset) 
`README`:
   
   
![image](https://user-images.githubusercontent.com/59641363/198537267-8c4c6a1b-92f8-4ac3-b4c8-d8b839b65eb6.png)
   
   ### TESTING INSTRUCTIONS
   
   - For the `helm-docs` pre-commit:
     - Check out project
     - Update pre-commit (`pre-commit install`)
     - Make some chart update (e.g. bump up the version in `Chart.yaml`) and 
stage the change
     - Try to commit. Git should raise an error complaining that a pre-commit 
check has failed
     - Run `pre-commit run helm-docs` to force execute the helm-docs 
generation, stage the resulting change and commit again
   - For the chart releaser fix: merge the PR and hope for helm chart v0.7.6 to 
be released!
   
   ### ADDITIONAL INFORMATION
   - [x] Has associated issue: #21806 (merge failed to release)
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Reply via email to