Yann-J commented on PR #21963: URL: https://github.com/apache/superset/pull/21963#issuecomment-1295767635
Alright @craig-rueda after much tweaking I have the CI now fairly clean! I finally opted not to run a separate Github action to check for `helm-docs`, since I see that CI will anyway run all the `pre-commit` checks, so these alone are enough. It was slightly harder than it should be, because of the above mentioned issue that makes using `brew` a bit harder on Github machines. There is still a CI failure with one of the cypress e2e tests, but I can see it's a known [flaky test](https://dashboard.cypress.io/projects/ukwxzo/analytics/flaky-tests/5201715e-e599-44ed-3368-c24dfbd9d03b-be408a3c-4249-d66a-22a1-010d2436d341), and is very unlikely to be related to the changes in this PR. Note that since this would (hopefully) be the first successful helm chart release since #20722 this should also force the metadata refresh in [artifacthub](https://artifacthub.io/packages/helm/superset/superset), and enable the 'verified publisher' badge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
