hughhhh commented on code in PR #22024:
URL: https://github.com/apache/superset/pull/22024#discussion_r1015720548


##########
superset/db_engine_specs/base.py:
##########
@@ -443,6 +452,9 @@ def get_dbapi_mapped_exception(cls, exception: Exception) 
-> Exception:
         """
         new_exception = cls.get_dbapi_exception_mapping().get(type(exception))
         if not new_exception:
+            # We are interested in just BigQuery exceptions
+            if cls.engine == EngineType.BIGQUERY:

Review Comment:
   a better check is if the class has the function `parse_error_exception`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Reply via email to