Antonio-RiveroMartnez commented on code in PR #22024:
URL: https://github.com/apache/superset/pull/22024#discussion_r1015722785
##########
superset/db_engine_specs/base.py:
##########
@@ -443,6 +452,9 @@ def get_dbapi_mapped_exception(cls, exception: Exception)
-> Exception:
"""
new_exception = cls.get_dbapi_exception_mapping().get(type(exception))
if not new_exception:
+ # We are interested in just BigQuery exceptions
+ if cls.engine == EngineType.BIGQUERY:
Review Comment:
They all have it because the base class have it, I had it that way initially
but our hooks and linting rules don't like it because `cls` would be the base
class and it checks with it instead of the BigQuery one for example. So, Was
that or ignoring the rule if possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
