lyndsiWilliams opened a new pull request, #22136: URL: https://github.com/apache/superset/pull/22136
<!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> ### SUMMARY <!--- Describe the change below, including rationale and design decisions --> This implements a flow in the new dataset creation page for when a table already has a dataset. It uses a simplified dataset fetch in the `AddDataset/index.tsx` file to cross-reference with the table list. If the table has a dataset, it gets a warning icon in the left panel. If the table is selected, the table's columns are still displayed, but the "Create Dataset" button is disabled and it has an info banner at the top informing the user of the pre-existing dataset with a link to that dataset in the upper-left corner of the alert. Clicking the "View Dataset" button in this alert will bring the user to the explore view of the existing dataset in a new tab. ### ANIMATED GIF / SCREENSHOT <!--- Skip this if not applicable --> #### Screenshot of selected table with existing dataset <img width="1388" alt="Screenshot 2022-11-15 at 7 01 47 PM" src="https://user-images.githubusercontent.com/55605634/202057625-a50027ee-bd71-483f-a32e-b3cebfa83990.png";> #### Left panel warning icons  #### "View dataset"  ### TESTING INSTRUCTIONS <!--- Required! What steps can be taken to manually verify the changes? --> - Go to `http://localhost:9000/dataset/add/?testing` - Select a database and a schema - Observe that any tables in the left panel with a pre-existing dataset will have a warning icon - Click a table with a dataset - Observe that the "Create dataset" button is disabled and there is an info banner at the top informing of the pre-existing dataset - Click "View dataset" in the alert - Observe that you are taken to the explore view of the existing dataset in a new tab ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
![https://user-images.githubusercontent.com/55605634/202057625-a50027ee-bd71-483f-a32e-b3cebfa83990.png"](https://user-images.githubusercontent.com/55605634/202057625-a50027ee-bd71-483f-a32e-b3cebfa83990.png"){kind=link}
