eric-briscoe commented on code in PR #22136:
URL: https://github.com/apache/superset/pull/22136#discussion_r1025421125
##########
superset-frontend/src/views/CRUD/data/dataset/AddDataset/DatasetPanel/DatasetPanel.tsx:
##########
@@ -54,8 +56,10 @@ const MARGIN_MULTIPLIER = 3;
const StyledHeader = styled.div<StyledHeaderProps>`
position: ${(props: StyledHeaderProps) => props.position};
- margin: ${({ theme }) => theme.gridUnit * MARGIN_MULTIPLIER}px;
- margin-top: ${({ theme }) => theme.gridUnit * (MARGIN_MULTIPLIER + 1)}px;
+ margin: ${({ theme }) => theme.gridUnit * (MARGIN_MULTIPLIER + 1)}px
+ ${({ theme }) => theme.gridUnit * MARGIN_MULTIPLIER}px
+ ${({ theme }) => theme.gridUnit * MARGIN_MULTIPLIER}px
+ ${({ theme }) => theme.gridUnit * (MARGIN_MULTIPLIER + 3)}px;
Review Comment:
These docs address how you can get props once and not have to make multiple
inline functions:
https://github.com/apache/superset/wiki/Emotion-Styling-Guidelines-and-Best-Practices#no-need-to-use-theme-the-hard-way
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
