eschutho commented on code in PR #22136:
URL: https://github.com/apache/superset/pull/22136#discussion_r1028634693
##########
superset-frontend/src/views/CRUD/data/dataset/AddDataset/index.tsx:
##########
@@ -73,6 +75,38 @@ export default function AddDataset() {
Reducer<Partial<DatasetObject> | null, DSReducerActionType>
>(datasetReducer, null);
const [hasColumns, setHasColumns] = useState(false);
+ const [linkedDatasets, setLinkedDatasets] = useState<DatasetObject[]>([]);
Review Comment:
how about just "physicalDatasets"? the name doesn't explain what they're
linked to, so maybe physicalDatasets will explain that they are just regular
datasets, but only the physical, not virtual, ones.. honestly you could
probably just say "datasets" and that would be fine, too. I don't think it's
necessary to completely describe them here.. just that it's a list of datasets
should be fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
