eschutho commented on code in PR #22136: URL: https://github.com/apache/superset/pull/22136#discussion_r1025855704
########## superset-frontend/src/views/CRUD/data/dataset/AddDataset/index.tsx: ########## @@ -73,6 +75,38 @@ export default function AddDataset() { Reducer<Partial<DatasetObject> | null, DSReducerActionType> >(datasetReducer, null); const [hasColumns, setHasColumns] = useState(false); + const [linkedDatasets, setLinkedDatasets] = useState<DatasetObject[]>([]); Review Comment: this is a nit, but has been tripping me up when reading the code. Just for naming purposes, this is a list of all datasets, right? I'm not clear on which part is linked. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org