zhaoyongjie commented on code in PR #22196:
URL: https://github.com/apache/superset/pull/22196#discussion_r1029942672
##########
superset/charts/data/api.py:
##########
@@ -130,6 +135,7 @@ def get_data(self, pk: int) -> Response:
"format", ChartDataResultFormat.JSON
)
json_body["result_type"] = request.args.get("type",
ChartDataResultType.FULL)
+ json_body["force"] = request.args.get("force", False)
Review Comment:
In order to handle `false` as a string in the force, an explicit type
conversion should be in here. for example:
```type
json_body["force"] =
explict_bool_conversion(request.args.get("force"))
```
##########
superset/charts/data/api.py:
##########
@@ -130,6 +135,7 @@ def get_data(self, pk: int) -> Response:
"format", ChartDataResultFormat.JSON
)
json_body["result_type"] = request.args.get("type",
ChartDataResultType.FULL)
+ json_body["force"] = request.args.get("force", False)
Review Comment:
In order to handle `false` as a string in the force, an explicit type
conversion should be in here. for example:
```Python
json_body["force"] =
explict_bool_conversion(request.args.get("force"))
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
