zhaoyongjie commented on code in PR #22196:
URL: https://github.com/apache/superset/pull/22196#discussion_r1029966009
##########
superset/charts/data/api.py:
##########
@@ -130,6 +135,7 @@ def get_data(self, pk: int) -> Response:
"format", ChartDataResultFormat.JSON
)
json_body["result_type"] = request.args.get("type",
ChartDataResultType.FULL)
+ json_body["force"] = request.args.get("force", False)
Review Comment:
if exists another deserialization helper on the json_body, the default value
of `request.args.get("force")` should be None instead of
`request.args.get("force", False)`, because the `request.args.get("force")`
will always return `Optional[str]`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
