mayurnewase commented on PR #22107:
URL: https://github.com/apache/superset/pull/22107#issuecomment-1333491588

   updated series limit to row limit, and added order control.
   
   @zhaoyongjie the `normalizeOrderBy` in core doesn't support this control 
panel yet and I didn't want to change anything in core in this PR so added 
order support in the buildQuery itself.
   Either this or need to something more hacky like below
   
   `orderby: normalizeOrderBy(
         {
           ...baseQueryObject,
           orderby: [
             [...baseQueryObject.orderby, !baseQueryObject.order_desc]
           ]
         }
       ).orderby`
   
   what do you think?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to