mayurnewase commented on PR #22107: URL: https://github.com/apache/superset/pull/22107#issuecomment-1334650225
> Just seeing this and catching up on the thread - this is great, thanks! > > I haven't looked at the code yet, but for myself or any other reviewer, I'm hopeful that this (or a followup) includes the latest best practices: • Generic X Axis • Standardized controls (normalizing/denormalizing for fast-viz switching) • Drill to Detail support > > Basically, trying to keep all the ECharts plugins current with all the first-class bells and whistles. Happy to provide support/references for any of the above if needed. > > Again, thanks, this is exciting! @rusackas 1. x and y axes are both metrics 2. controls are standard but for fast switching don't think there is any other chart with x and y and 1 more metric for bubble size, so not sure how I can test the switch. 3. I will add cross filter and drill to detail as soon as this PR gets merged, because it may need other modifications and new tests. possible to get 1 more review? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
