cccs-RyanK commented on code in PR #22084:
URL: https://github.com/apache/superset/pull/22084#discussion_r1037141878
##########
superset-frontend/src/SqlLab/components/SqlEditorLeftBar/SqlEditorLeftBar.test.jsx:
##########
@@ -94,7 +94,7 @@ test('table should be visible when expanded is true', async
() => {
expect(dbSelect).toBeInTheDocument();
expect(schemaSelect).toBeInTheDocument();
expect(dropdown).toBeInTheDocument();
- expect(abUser).toHaveLength(2);
+ expect(abUser).toHaveLength(1);
Review Comment:
This test adds one item into a 'multi' select component and then selects it.
With the new behaviour, that counts as selecting all which renders a custom tag
with the total number of items selected. This test would fail because it
expected the single tag to be rendered in the select component when that is no
longer the expected behaviour, so I changed the test.
Another option is to make it so that the select all functionality is
disabled in the case where there is only one item in the options. Please let me
know your thoughts
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
