cccs-RyanK commented on code in PR #22084:
URL: https://github.com/apache/superset/pull/22084#discussion_r1069616803
##########
superset-frontend/src/components/Select/AsyncSelect.tsx:
##########
@@ -527,7 +527,7 @@ const AsyncSelect = forwardRef(
)
}
oneLine={oneLine}
- tagRender={oneLine ? oneLineTagRender : undefined}
+ tagRender={customTagRender}
Review Comment:
Oh I see. The only difference between `customTagRender` and the default is
the inclusion of the `onMouseDown` handler that prevents the dropdown from
opening when clicking the tag icons. This was added for the `oneLine` mode and
it seemed useful for the regular use case, but i can add a check to not include
it when the component is not in `oneLine` mode?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
