rusackas commented on code in PR #22150:
URL: https://github.com/apache/superset/pull/22150#discussion_r1050028008
##########
superset-frontend/src/dashboard/components/gridComponents/Tabs.jsx:
##########
@@ -224,9 +224,12 @@ export class Tabs extends React.PureComponent {
title: t('Delete dashboard tab?'),
content: (
<span>
- Deleting a tab will remove all content within it. You may still
- reverse this action with the <b>undo</b> button (cmd + z) until you
- save your changes.
+ {t(
Review Comment:
I wonder if template literals would make this block a little more
legible/parsable. Not a dealbreaker.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
