rusackas commented on PR #22150: URL: https://github.com/apache/superset/pull/22150#issuecomment-1353669872
This generally looks good to me! I added a couple clarifying questions. In general, there seems like only one real pint of contention, which is that I'm not sure we want to include the colon-space combo in the translated strings, as the word(s) without the punctuation may provide utility in other settings. For example, `name: ` is translated, but we might just want to leverage `name` which is _probably_ already translated. I think this applies to several instances. Curious if others with experience in translations (e.g. @geido @ktmud @etr2460) might feel differently. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
