john-bodley commented on code in PR #22358:
URL: https://github.com/apache/superset/pull/22358#discussion_r1052549607
##########
superset/dashboards/dao.py:
##########
@@ -40,11 +40,22 @@ class DashboardDAO(BaseDAO):
base_filter = DashboardAccessFilter
@staticmethod
- def get_by_id_or_slug(id_or_slug: str) -> Dashboard:
- dashboard = Dashboard.get(id_or_slug)
Review Comment:
Doesn't FAB fetch all the relationships as well, i.e., why do we need to
explicitly compose a query which joins all the related models?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
