dpgaspar commented on code in PR #22358:
URL: https://github.com/apache/superset/pull/22358#discussion_r1055358727
##########
tests/integration_tests/dashboards/api_tests.py:
##########
@@ -225,15 +225,36 @@ def test_get_dashboard_datasets_not_found(self):
response = self.get_assert_metric(uri, "get_datasets")
self.assertEqual(response.status_code, 404)
- @pytest.mark.usefixtures("load_world_bank_dashboard_with_slices")
- def test_get_draft_dashboard_datasets(self):
+ @pytest.mark.usefixtures("create_dashboards")
+ def test_get_gamma_dashboard_datasets(self):
"""
- All users should have access to dashboards without roles
Review Comment:
yes this PR removes it. I'm setting /api/v1/dashboard/<1> to the same level
of authorization has /api/v1/dashboard/, this mean the dashboard metadata has
the same access level
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
