kgabryje commented on code in PR #22460:
URL: https://github.com/apache/superset/pull/22460#discussion_r1053285752
##########
superset-frontend/cypress-base/cypress/integration/dashboard/drilltodetail.test.ts:
##########
@@ -172,21 +172,21 @@ describe('Drill to detail modal', () => {
openModalFromMenu('big_number_total');
// checking the data
cy.getBySel('row-count-label').should('contain', '75.7k rows');
- cy.get('.virtual-table-cell').then($rows => {
+ cy.get('.virtual-table-cell').should($rows => {
expect($rows).to.contain('Amy');
});
// checking the paginated data
cy.get('.ant-pagination-item')
.should('have.length', 6)
- .then($pages => {
+ .should($pages => {
Review Comment:
Cool, I didn't know that `should` waits and `then` doesn't!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
