codyml commented on code in PR #22460:
URL: https://github.com/apache/superset/pull/22460#discussion_r1053316071
##########
superset-frontend/cypress-base/cypress/integration/dashboard/nativeFilters.test.ts:
##########
@@ -202,6 +202,7 @@ function openVerticalFilterBar() {
function setFilterBarOrientation(orientation: 'vertical' | 'horizontal') {
cy.getBySel('filterbar-orientation-icon').click();
+ cy.wait(250);
Review Comment:
Haha no worries! For this one, the timeout was for after the `.click()` to
open the menu. The issue seemed to be that the loading of the page caused some
scrolling action while the menu was opening, which disrupted Cypress's ability
to click on the menu item even though it is able to find it, so this `.wait`
hopefully will let the scrolling finish in more cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
